added separate strikes for downloading metadata

README.md

@@ -183,15 +183,16 @@ services:
       - QUEUECLEANER__ENABLED=true
       - QUEUECLEANER__IGNORED_DOWNLOADS_PATH=/ignored.txt
       - QUEUECLEANER__RUNSEQUENTIALLY=true
-      - QUEUECLEANER__IMPORT_FAILED_MAX_STRIKES=5
+      - QUEUECLEANER__IMPORT_FAILED_MAX_STRIKES=3
       - QUEUECLEANER__IMPORT_FAILED_IGNORE_PRIVATE=false
       - QUEUECLEANER__IMPORT_FAILED_DELETE_PRIVATE=false
       # - QUEUECLEANER__IMPORT_FAILED_IGNORE_PATTERNS__0=title mismatch
       # - QUEUECLEANER__IMPORT_FAILED_IGNORE_PATTERNS__1=manual import required
-      - QUEUECLEANER__STALLED_MAX_STRIKES=5
+      - QUEUECLEANER__STALLED_MAX_STRIKES=3
       - QUEUECLEANER__STALLED_RESET_STRIKES_ON_PROGRESS=false
       - QUEUECLEANER__STALLED_IGNORE_PRIVATE=false
       - QUEUECLEANER__STALLED_DELETE_PRIVATE=false
+      - QUEUECLEANER__DOWNLOADING_METADATA_MAX_STRIKES=3
 
       - CONTENTBLOCKER__ENABLED=true
       - CONTENTBLOCKER__IGNORED_DOWNLOADS_PATH=/ignored.txt

code/Common/Configuration/DownloadCleaner/Category.cs

@@ -3,7 +3,7 @@ using Microsoft.Extensions.Configuration;
 
 namespace Common.Configuration.DownloadCleaner;
 
-public sealed record CleanCategory : IConfig
+public sealed record Category : IConfig
 {
     public required string Name { get; init; }
 

code/Common/Configuration/DownloadCleaner/DownloadCleanerConfig.cs

@@ -8,8 +8,8 @@ public sealed record DownloadCleanerConfig : IJobConfig, IIgnoredDownloadsConfig
     public const string SectionName = "DownloadCleaner";
     
     public bool Enabled { get; init; }
-
-    public List<CleanCategory>? Categories { get; init; }
+    
+    public List<Category>? Categories { get; init; }
 
     [ConfigurationKeyName("DELETE_PRIVATE")]
     public bool DeletePrivate { get; init; }
@@ -17,15 +17,6 @@ public sealed record DownloadCleanerConfig : IJobConfig, IIgnoredDownloadsConfig
     [ConfigurationKeyName("IGNORED_DOWNLOADS_PATH")]
     public string? IgnoredDownloadsPath { get; init; }
 
-    [ConfigurationKeyName("UNLINKED_TARGET_CATEGORY")]
-    public string UnlinkedTargetCategory { get; init; } = "cleanuperr-unlinked";
-
-    [ConfigurationKeyName("UNLINKED_IGNORED_ROOT_DIR")]
-    public string UnlinkedIgnoredRootDir { get; init; } = string.Empty;
-    
-    [ConfigurationKeyName("UNLINKED_CATEGORIES")]
-    public List<string>? UnlinkedCategories { get; init; }
-
     public void Validate()
     {
         if (!Enabled)
@@ -40,34 +31,9 @@ public sealed record DownloadCleanerConfig : IJobConfig, IIgnoredDownloadsConfig
 
         if (Categories?.GroupBy(x => x.Name).Any(x => x.Count() > 1) is true)
         {
-            throw new ValidationException("duplicated clean categories found");
+            throw new ValidationException("duplicated categories found");
         }
         
         Categories?.ForEach(x => x.Validate());
-        
-        if (string.IsNullOrEmpty(UnlinkedTargetCategory))
-        {
-            return;
-        }
-
-        if (UnlinkedCategories?.Count is null or 0)
-        {
-            throw new ValidationException("no unlinked categories configured");
-        }
-
-        if (UnlinkedCategories.Contains(UnlinkedTargetCategory))
-        {
-            throw new ValidationException($"{SectionName.ToUpperInvariant()}__UNLINKED_TARGET_CATEGORY should not be present in {SectionName.ToUpperInvariant()}__UNLINKED_CATEGORIES");
-        }
-
-        if (UnlinkedCategories.Any(string.IsNullOrEmpty))
-        {
-            throw new ValidationException("empty unlinked category filter found");
-        }
-
-        if (!string.IsNullOrEmpty(UnlinkedIgnoredRootDir) && !Directory.Exists(UnlinkedIgnoredRootDir))
-        {
-            throw new ValidationException($"{UnlinkedIgnoredRootDir} root directory does not exist");
-        }
     }
 }

code/Common/Configuration/Notification/NotificationConfig.cs

@@ -15,16 +15,8 @@ public abstract record NotificationConfig
     
     [ConfigurationKeyName("ON_DOWNLOAD_CLEANED")]
     public bool OnDownloadCleaned { get; init; }
-    
-    [ConfigurationKeyName("ON_CATEGORY_CHANGED")]
-    public bool OnCategoryChanged { get; init; }
 
-    public bool IsEnabled =>
-        OnImportFailedStrike ||
-        OnStalledStrike ||
-        OnQueueItemDeleted ||
-        OnDownloadCleaned ||
-        OnCategoryChanged;
+    public bool IsEnabled => OnImportFailedStrike || OnStalledStrike || OnQueueItemDeleted || OnDownloadCleaned;
 
     public abstract bool IsValid();
 }

code/Common/Configuration/QueueCleaner/QueueCleanerConfig.cs

@@ -24,7 +24,7 @@ public sealed record QueueCleanerConfig : IJobConfig, IIgnoredDownloadsConfig
     public bool ImportFailedDeletePrivate { get; init; }
     
     [ConfigurationKeyName("IMPORT_FAILED_IGNORE_PATTERNS")]
-    public List<string>? ImportFailedIgnorePatterns { get; init; }
+    public IReadOnlyList<string>? ImportFailedIgnorePatterns { get; init; }
     
     [ConfigurationKeyName("STALLED_MAX_STRIKES")]
     public ushort StalledMaxStrikes { get; init; }
@@ -38,16 +38,24 @@ public sealed record QueueCleanerConfig : IJobConfig, IIgnoredDownloadsConfig
     [ConfigurationKeyName("STALLED_DELETE_PRIVATE")]
     public bool StalledDeletePrivate { get; init; }
 
+    [ConfigurationKeyName("DOWNLOADING_METADATA_MAX_STRIKES")]
+    public ushort DownloadingMetadataMaxStrikes { get; init; }
+    
     public void Validate()
     {
         if (ImportFailedMaxStrikes is > 0 and < 3)
         {
-            throw new ValidationException("the minimum value for IMPORT_FAILED_MAX_STRIKES must be 3");
+            throw new ValidationException($"the minimum value for {SectionName.ToUpperInvariant()}__IMPORT_FAILED_MAX_STRIKES must be 3");
         }
 
         if (StalledMaxStrikes is > 0 and < 3)
         {
-            throw new ValidationException("the minimum value for STALLED_MAX_STRIKES must be 3");
+            throw new ValidationException($"the minimum value for {SectionName.ToUpperInvariant()}__STALLED_MAX_STRIKES must be 3");
+        }
+        
+        if (DownloadingMetadataMaxStrikes is > 0 and < 3)
+        {
+            throw new ValidationException($"the minimum value for {SectionName.ToUpperInvariant()}__DOWNLOADING_METADATA_MAX_STRIKES must be 3");
         }
     }
 }

code/Common/Exceptions/FatalException.cs

@@ -1,12 +0,0 @@
-namespace Common.Exceptions;
-
-public class FatalException : Exception
-{
-    public FatalException()
-    {
-    }
-
-    public FatalException(string message) : base(message)
-    {
-    }
-}

code/Domain/Enums/DeleteReason.cs

@@ -1,4 +1,4 @@
-namespace Domain.Enums;
+namespace Domain.Enums;
 
 public enum DeleteReason
 {

code/Domain/Models/Deluge/Response/TorrentStatus.cs

@@ -17,7 +17,7 @@ public sealed record TorrentStatus
     [JsonProperty("total_done")]
     public long TotalDone { get; init; }
     
-    public string? Label { get; set; }
+    public string? Label { get; init; }
     
     [JsonProperty("seeding_time")]
     public long SeedingTime { get; init; }
@@ -25,9 +25,6 @@ public sealed record TorrentStatus
     public float Ratio { get; init; }
     
     public required IReadOnlyList<Tracker> Trackers { get; init; }
-    
-    [JsonProperty("download_location")]
-    public required string DownloadLocation { get; init; }
 }
 
 public sealed record Tracker

code/Executable/DependencyInjection/MainDI.cs

@@ -17,9 +17,7 @@ public static class MainDI
             .AddLogging(builder => builder.ClearProviders().AddConsole())
             .AddHttpClients(configuration)
             .AddConfiguration(configuration)
-            .AddMemoryCache(options => {
-                options.ExpirationScanFrequency = TimeSpan.FromMinutes(1);
-            })
+            .AddMemoryCache()
             .AddServices()
             .AddQuartzServices(configuration)
             .AddNotifications(configuration)
@@ -29,7 +27,6 @@ public static class MainDI
                 config.AddConsumer<NotificationConsumer<StalledStrikeNotification>>();
                 config.AddConsumer<NotificationConsumer<QueueItemDeletedNotification>>();
                 config.AddConsumer<NotificationConsumer<DownloadCleanedNotification>>();
-                config.AddConsumer<NotificationConsumer<CategoryChangedNotification>>();
 
                 config.UsingInMemory((context, cfg) =>
                 {
@@ -39,7 +36,6 @@ public static class MainDI
                         e.ConfigureConsumer<NotificationConsumer<StalledStrikeNotification>>(context);
                         e.ConfigureConsumer<NotificationConsumer<QueueItemDeletedNotification>>(context);
                         e.ConfigureConsumer<NotificationConsumer<DownloadCleanedNotification>>(context);
-                        e.ConfigureConsumer<NotificationConsumer<CategoryChangedNotification>>(context);
                         e.ConcurrentMessageLimit = 1;
                         e.PrefetchCount = 1;
                     });

code/Executable/DependencyInjection/ServicesDI.cs

@@ -10,7 +10,6 @@ using Infrastructure.Verticals.DownloadClient;
 using Infrastructure.Verticals.DownloadClient.Deluge;
 using Infrastructure.Verticals.DownloadClient.QBittorrent;
 using Infrastructure.Verticals.DownloadClient.Transmission;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.QueueCleaner;
 
@@ -28,9 +27,6 @@ public static class ServicesDI
             .AddTransient<ContentBlocker>()
             .AddTransient<DownloadCleaner>()
             .AddTransient<IFilenameEvaluator, FilenameEvaluator>()
-            .AddTransient<IHardLinkFileService, HardLinkFileService>()
-            .AddTransient<UnixHardLinkFileService>()
-            .AddTransient<WindowsHardLinkFileService>()
             .AddTransient<DummyDownloadService>()
             .AddTransient<QBitService>()
             .AddTransient<DelugeService>()

code/Executable/appsettings.Development.json

@@ -3,7 +3,7 @@
   "HTTP_MAX_RETRIES": 0,
   "HTTP_TIMEOUT": 10,
   "Logging": {
-    "LogLevel": "Verbose",
+    "LogLevel": "Debug",
     "Enhanced": true,
     "File": {
       "Enabled": false,
@@ -34,7 +34,8 @@
     "STALLED_MAX_STRIKES": 3,
     "STALLED_RESET_STRIKES_ON_PROGRESS": true,
     "STALLED_IGNORE_PRIVATE": true,
-    "STALLED_DELETE_PRIVATE": false
+    "STALLED_DELETE_PRIVATE": false,
+    "DOWNLOADING_METADATA_MAX_STRIKES": 3
   },
   "DownloadCleaner": {
     "Enabled": false,
@@ -44,15 +45,9 @@
         "Name": "tv-sonarr",
         "MAX_RATIO": -1,
         "MIN_SEED_TIME": 0,
-        "MAX_SEED_TIME": 240
+        "MAX_SEED_TIME": -1
       }
     ],
-    "UNLINKED_TARGET_CATEGORY": "cleanuperr-unlinked",
-    "UNLINKED_IGNORED_ROOT_DIR": "",
-    "UNLINKED_CATEGORIES": [
-      "tv-sonarr",
-      "radarr"
-    ],
     "IGNORED_DOWNLOADS_PATH": "../test/data/cleanuperr/ignored_downloads"
   },
   "DOWNLOAD_CLIENT": "qbittorrent",

code/Executable/appsettings.json

@@ -31,15 +31,13 @@
     "STALLED_MAX_STRIKES": 0,
     "STALLED_RESET_STRIKES_ON_PROGRESS": false,
     "STALLED_IGNORE_PRIVATE": false,
-    "STALLED_DELETE_PRIVATE": false
+    "STALLED_DELETE_PRIVATE": false,
+    "DOWNLOADING_METADATA_MAX_STRIKES": 0
   },
   "DownloadCleaner": {
     "Enabled": false,
     "DELETE_PRIVATE": false,
     "CATEGORIES": [],
-    "UNLINKED_TARGET_CATEGORY": "cleanuperr-unlinked",
-    "UNLINKED_IGNORED_ROOT_DIR": "",
-    "UNLINKED_CATEGORIES": [],
     "IGNORED_DOWNLOADS_PATH": ""
   },
   "DOWNLOAD_CLIENT": "none",

code/Infrastructure.Tests/Verticals/DownloadClient/DownloadServiceFixture.cs

@@ -1,10 +1,9 @@
-using Common.Configuration.ContentBlocker;
+using Common.Configuration.ContentBlocker;
 using Common.Configuration.DownloadCleaner;
 using Common.Configuration.QueueCleaner;
 using Infrastructure.Interceptors;
 using Infrastructure.Verticals.ContentBlocker;
 using Infrastructure.Verticals.DownloadClient;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.Notifications;
 using Microsoft.Extensions.Caching.Memory;
@@ -57,7 +56,6 @@ public class DownloadServiceFixture : IDisposable
         var filenameEvaluator = Substitute.For<IFilenameEvaluator>();
         var notifier = Substitute.For<INotificationPublisher>();
         var dryRunInterceptor = Substitute.For<IDryRunInterceptor>();
-        var hardlinkFileService = Substitute.For<IHardLinkFileService>();
 
         return new TestDownloadService(
             Logger,
@@ -68,8 +66,7 @@ public class DownloadServiceFixture : IDisposable
             filenameEvaluator,
             Striker,
             notifier,
-            dryRunInterceptor,
-            hardlinkFileService
+            dryRunInterceptor
         );
     }
 

code/Infrastructure.Tests/Verticals/DownloadClient/DownloadServiceTests.cs

@@ -133,7 +133,7 @@ public class DownloadServiceTests : IClassFixture<DownloadServiceFixture>
         public void WhenRatioAndMinSeedTimeReached_ShouldReturnTrue()
         {
             // Arrange
-            CleanCategory category = new()
+            Category category = new()
             {
                 Name = "test",
                 MaxRatio = 1.0,
@@ -159,7 +159,7 @@ public class DownloadServiceTests : IClassFixture<DownloadServiceFixture>
         public void WhenRatioReachedAndMinSeedTimeNotReached_ShouldReturnFalse()
         {
             // Arrange
-            CleanCategory category = new()
+            Category category = new()
             {
                 Name = "test",
                 MaxRatio = 1.0,
@@ -185,7 +185,7 @@ public class DownloadServiceTests : IClassFixture<DownloadServiceFixture>
         public void WhenMaxSeedTimeReached_ShouldReturnTrue()
         {
             // Arrange
-            CleanCategory category = new()
+            Category category = new()
             {
                 Name = "test",
                 MaxRatio = -1,
@@ -211,7 +211,7 @@ public class DownloadServiceTests : IClassFixture<DownloadServiceFixture>
         public void WhenNeitherConditionMet_ShouldReturnFalse()
         {
             // Arrange
-            CleanCategory category = new()
+            Category category = new()
             {
                 Name = "test",
                 MaxRatio = 2.0,

code/Infrastructure.Tests/Verticals/DownloadClient/TestDownloadService.cs

@@ -1,4 +1,4 @@
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 using System.Text.RegularExpressions;
 using Common.Configuration.ContentBlocker;
 using Common.Configuration.DownloadCleaner;
@@ -7,7 +7,6 @@ using Domain.Enums;
 using Infrastructure.Interceptors;
 using Infrastructure.Verticals.ContentBlocker;
 using Infrastructure.Verticals.DownloadClient;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.Notifications;
 using Microsoft.Extensions.Caching.Memory;
@@ -27,11 +26,10 @@ public class TestDownloadService : DownloadService
         IFilenameEvaluator filenameEvaluator,
         IStriker striker,
         INotificationPublisher notifier,
-        IDryRunInterceptor dryRunInterceptor,
-        IHardLinkFileService hardLinkFileService
+        IDryRunInterceptor dryRunInterceptor
     ) : base(
         logger, queueCleanerConfig, contentBlockerConfig, downloadCleanerConfig, cache,
-        filenameEvaluator, striker, notifier, dryRunInterceptor, hardLinkFileService
+        filenameEvaluator, striker, notifier, dryRunInterceptor
     )
     {
     }
@@ -42,14 +40,12 @@ public class TestDownloadService : DownloadService
     public override Task<BlockFilesResult> BlockUnwantedFilesAsync(string hash, BlocklistType blocklistType,
         ConcurrentBag<string> patterns, ConcurrentBag<Regex> regexes, IReadOnlyList<string> ignoredDownloads) => Task.FromResult(new BlockFilesResult());
     public override Task DeleteDownload(string hash) => Task.CompletedTask;
-    public override Task CreateCategoryAsync(string name) => Task.CompletedTask;
-    public override Task<List<object>?> GetSeedingDownloads() => Task.FromResult<List<object>?>(null);
-    public override List<object>? FilterDownloadsToBeCleanedAsync(List<object>? downloads, List<CleanCategory> categories) => null;
-    public override List<object>? FilterDownloadsToChangeCategoryAsync(List<object>? downloads, List<string> categories) => null;
-    public override Task CleanDownloadsAsync(List<object>? downloads, List<CleanCategory> categoriesToClean, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads) => Task.CompletedTask;
-    public override Task ChangeCategoryForNoHardLinksAsync(List<object>? downloads, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads) => Task.CompletedTask;
+    public override Task<List<object>?> GetAllDownloadsToBeCleaned(List<Category> categories) => Task.FromResult<List<object>?>(null);
+    public override Task CleanDownloads(List<object> downloads, List<Category> categoriesToClean, HashSet<string> excludedHashes,
+        IReadOnlyList<string> ignoredDownloads) => Task.CompletedTask;
+
     // Expose protected methods for testing
     public new void ResetStrikesOnProgress(string hash, long downloaded) => base.ResetStrikesOnProgress(hash, downloaded);
     public new Task<bool> StrikeAndCheckLimit(string hash, string itemName, StrikeType strikeType) => base.StrikeAndCheckLimit(hash, itemName, strikeType);
-    public new SeedingCheckResult ShouldCleanDownload(double ratio, TimeSpan seedingTime, CleanCategory category) => base.ShouldCleanDownload(ratio, seedingTime, category);
+    public new SeedingCheckResult ShouldCleanDownload(double ratio, TimeSpan seedingTime, Category category) => base.ShouldCleanDownload(ratio, seedingTime, category);
 }

code/Infrastructure/Infrastructure.csproj

@@ -13,12 +13,11 @@
 
     <ItemGroup>
       <PackageReference Include="FLM.QBittorrent" Version="1.0.0" />
-      <PackageReference Include="FLM.Transmission" Version="1.0.3" />
+      <PackageReference Include="FLM.Transmission" Version="1.0.2" />
       <PackageReference Include="Mapster" Version="7.4.0" />
       <PackageReference Include="MassTransit" Version="8.3.6" />
       <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="9.0.2" />
       <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.2" />
-      <PackageReference Include="Mono.Posix.NETStandard" Version="1.0.0" />
       <PackageReference Include="Quartz" Version="3.13.1" />
       <PackageReference Include="Scrutor" Version="6.0.1" />
     </ItemGroup>

code/Infrastructure/Verticals/ContentBlocker/BlocklistProvider.cs

@@ -43,7 +43,7 @@ public sealed class BlocklistProvider
     {
         if (_initialized)
         {
-            _logger.LogTrace("blocklists already loaded");
+            _logger.LogDebug("blocklists already loaded");
             return;
         }
         

code/Infrastructure/Verticals/DownloadCleaner/DownloadCleaner.cs

@@ -21,8 +21,6 @@ public sealed class DownloadCleaner : GenericHandler
     private readonly IgnoredDownloadsProvider<DownloadCleanerConfig> _ignoredDownloadsProvider;
     private readonly HashSet<string> _excludedHashes = [];
     
-    private static bool _hardLinkCategoryCreated;
-    
     public DownloadCleaner(
         ILogger<DownloadCleaner> logger,
         IOptions<DownloadCleanerConfig> config,
@@ -67,20 +65,13 @@ public sealed class DownloadCleaner : GenericHandler
         IReadOnlyList<string> ignoredDownloads = await _ignoredDownloadsProvider.GetIgnoredDownloads();
         
         await _downloadService.LoginAsync();
-        List<object>? downloads = await _downloadService.GetSeedingDownloads();
-        List<object>? downloadsToChangeCategory = null;
-        
-        if (!string.IsNullOrEmpty(_config.UnlinkedTargetCategory) && _config.UnlinkedCategories?.Count > 0)
-        {
-            if (!_hardLinkCategoryCreated)
-            {
-                _logger.LogDebug("creating category {cat}", _config.UnlinkedTargetCategory);
 
-                await _downloadService.CreateCategoryAsync(_config.UnlinkedTargetCategory);
-                _hardLinkCategoryCreated = true;
-            }
-            
-            downloadsToChangeCategory = _downloadService.FilterDownloadsToChangeCategoryAsync(downloads, _config.UnlinkedCategories);
+        List<object>? downloads = await _downloadService.GetAllDownloadsToBeCleaned(_config.Categories);
+
+        if (downloads?.Count is null or 0)
+        {
+            _logger.LogDebug("no downloads found in the download client");
+            return;
         }
 
         // wait for the downloads to appear in the arr queue
@@ -90,16 +81,7 @@ public sealed class DownloadCleaner : GenericHandler
         await ProcessArrConfigAsync(_radarrConfig, InstanceType.Radarr, true);
         await ProcessArrConfigAsync(_lidarrConfig, InstanceType.Lidarr, true);
         
-        _logger.LogTrace("looking for downloads to change category");
-        await _downloadService.ChangeCategoryForNoHardLinksAsync(downloadsToChangeCategory, _excludedHashes, ignoredDownloads);
-        
-        List<object>? downloadsToClean = _downloadService.FilterDownloadsToBeCleanedAsync(downloads, _config.Categories);
-        
-        // release unused objects
-        downloads = null;
-        
-        _logger.LogTrace("looking for downloads to clean");
-        await _downloadService.CleanDownloadsAsync(downloadsToClean, _config.Categories, _excludedHashes, ignoredDownloads);
+        await _downloadService.CleanDownloads(downloads, _config.Categories, _excludedHashes, ignoredDownloads);
     }
 
     protected override async Task ProcessInstanceAsync(ArrInstance instance, InstanceType instanceType)

code/Infrastructure/Verticals/DownloadClient/Deluge/DelugeClient.cs

@@ -2,7 +2,6 @@
 using System.Text.Json.Serialization;
 using Common.Configuration;
 using Common.Configuration.DownloadClient;
-using Common.Exceptions;
 using Domain.Models.Deluge.Exceptions;
 using Domain.Models.Deluge.Request;
 using Domain.Models.Deluge.Response;
@@ -28,8 +27,7 @@ public sealed class DelugeClient
         "label",
         "seeding_time",
         "ratio",
-        "trackers",
-        "download_location"
+        "trackers"
     ];
     
     public DelugeClient(IOptions<DelugeConfig> config, IHttpClientFactory httpClientFactory)
@@ -44,42 +42,11 @@ public sealed class DelugeClient
         return await SendRequest<bool>("auth.login", _config.Password);
     }
 
-    public async Task<bool> IsConnected()
-    {
-        return await SendRequest<bool>("web.connected");
-    }
-
-    public async Task<bool> Connect()
-    {
-        string? firstHost = await GetHost();
-
-        if (string.IsNullOrEmpty(firstHost))
-        {
-            return false;
-        }
-
-        var result = await SendRequest<List<string>?>("web.connect", firstHost);
-        
-        return result?.Count > 0;
-    }
-
     public async Task<bool> Logout()
     {
         return await SendRequest<bool>("auth.delete_session");
     }
 
-    public async Task<string?> GetHost()
-    {
-        var hosts = await SendRequest<List<List<string>?>?>("web.get_hosts");
-
-        if (hosts?.Count > 1)
-        {
-            throw new FatalException("multiple Deluge hosts found - please connect to only one host");
-        }
-        
-        return hosts?.FirstOrDefault()?.FirstOrDefault();
-    }
-
     public async Task<List<DelugeTorrent>> ListTorrents(Dictionary<string, string>? filters = null)
     {
         filters ??= new Dictionary<string, string>();
@@ -180,7 +147,7 @@ public sealed class DelugeClient
         return responseJson;
     }
 
-    private static DelugeRequest CreateRequest(string method, params object[] parameters)
+    private DelugeRequest CreateRequest(string method, params object[] parameters)
     {
         if (String.IsNullOrWhiteSpace(method))
         {
@@ -226,19 +193,4 @@ public sealed class DelugeClient
 
         return webResponse.Result;
     }
-
-    public async Task<IReadOnlyList<string>> GetLabels()
-    {
-        return await SendRequest<IReadOnlyList<string>>("label.get_labels");
-    }
-    
-    public async Task CreateLabel(string label)
-    {
-        await SendRequest<DelugeResponse<object>>("label.add", label);
-    }
-
-    public async Task SetTorrentLabel(string hash, string newLabel)
-    {
-        await SendRequest<DelugeResponse<object>>("label.set_torrent", hash, newLabel);
-    }
 }

code/Infrastructure/Verticals/DownloadClient/Deluge/DelugeService.cs

@@ -5,14 +5,12 @@ using Common.Configuration.ContentBlocker;
 using Common.Configuration.DownloadCleaner;
 using Common.Configuration.DownloadClient;
 using Common.Configuration.QueueCleaner;
-using Common.Exceptions;
 using Domain.Enums;
 using Domain.Models.Deluge.Response;
 using Infrastructure.Extensions;
 using Infrastructure.Interceptors;
 using Infrastructure.Verticals.ContentBlocker;
 using Infrastructure.Verticals.Context;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.Notifications;
 using Microsoft.Extensions.Caching.Memory;
@@ -36,11 +34,10 @@ public class DelugeService : DownloadService, IDelugeService
         IFilenameEvaluator filenameEvaluator,
         IStriker striker,
         INotificationPublisher notifier,
-        IDryRunInterceptor dryRunInterceptor,
-        IHardLinkFileService hardLinkFileService
+        IDryRunInterceptor dryRunInterceptor
     ) : base(
         logger, queueCleanerConfig, contentBlockerConfig, downloadCleanerConfig, cache,
-        filenameEvaluator, striker, notifier, dryRunInterceptor, hardLinkFileService
+        filenameEvaluator, striker, notifier, dryRunInterceptor
     )
     {
         config.Value.Validate();
@@ -50,11 +47,6 @@ public class DelugeService : DownloadService, IDelugeService
     public override async Task LoginAsync()
     {
         await _client.LoginAsync();
-
-        if (!await _client.IsConnected() && !await _client.Connect())
-        {
-            throw new FatalException("Deluge WebUI is not connected to the daemon");
-        }
     }
 
     /// <inheritdoc/>
@@ -132,6 +124,9 @@ public class DelugeService : DownloadService, IDelugeService
             return result;
         }
         
+        var ceva = await _client.GetTorrentExtended(hash);
+        
+        
         if (ignoredDownloads.Count > 0 && download.ShouldIgnore(ignoredDownloads))
         {
             _logger.LogInformation("skip | download is ignored | {name}", download.Name);
@@ -214,51 +209,26 @@ public class DelugeService : DownloadService, IDelugeService
         return result;
     }
 
-    public override async Task<List<object>?> GetSeedingDownloads()
+    public override async Task<List<object>?> GetAllDownloadsToBeCleaned(List<Category> categories)
     {
         return (await _client.GetStatusForAllTorrents())
             ?.Where(x => !string.IsNullOrEmpty(x.Hash))
             .Where(x => x.State?.Equals("seeding", StringComparison.InvariantCultureIgnoreCase) is true)
+            .Where(x => categories.Any(cat => cat.Name.Equals(x.Label, StringComparison.InvariantCultureIgnoreCase)))
             .Cast<object>()
             .ToList();
     }
 
-    public override List<object>? FilterDownloadsToBeCleanedAsync(List<object>? downloads, List<CleanCategory> categories) =>
-        downloads
-            ?.Cast<TorrentStatus>()
-            .Where(x => categories.Any(cat => cat.Name.Equals(x.Label, StringComparison.InvariantCultureIgnoreCase)))
-            .Cast<object>()
-            .ToList();
-
-    public override List<object>? FilterDownloadsToChangeCategoryAsync(List<object>? downloads, List<string> categories) =>
-        downloads
-            ?.Cast<TorrentStatus>()
-            .Where(x => !string.IsNullOrEmpty(x.Hash))
-            .Where(x => categories.Any(cat => cat.Equals(x.Label, StringComparison.InvariantCultureIgnoreCase)))
-            .Cast<object>()
-            .ToList();
-
     /// <inheritdoc/>
-    public override async Task CleanDownloadsAsync(List<object>? downloads, List<CleanCategory> categoriesToClean, HashSet<string> excludedHashes,
+    public override async Task CleanDownloads(List<object> downloads, List<Category> categoriesToClean, HashSet<string> excludedHashes,
         IReadOnlyList<string> ignoredDownloads)
     {
-        if (downloads?.Count is null or 0)
-        {
-            return;
-        }
-        
         foreach (TorrentStatus download in downloads)
         {
             if (string.IsNullOrEmpty(download.Hash))
             {
                 continue;
             }
-            
-            if (excludedHashes.Any(x => x.Equals(download.Hash, StringComparison.InvariantCultureIgnoreCase)))
-            {
-                _logger.LogDebug("skip | download is used by an arr | {name}", download.Name);
-                continue;
-            }
 
             if (ignoredDownloads.Count > 0 && download.ShouldIgnore(ignoredDownloads))
             {
@@ -266,13 +236,19 @@ public class DelugeService : DownloadService, IDelugeService
                 continue;
             }
             
-            CleanCategory? category = categoriesToClean
+            Category? category = categoriesToClean
                 .FirstOrDefault(x => x.Name.Equals(download.Label, StringComparison.InvariantCultureIgnoreCase));
 
             if (category is null)
             {
                 continue;
             }
+            
+            if (excludedHashes.Any(x => x.Equals(download.Hash, StringComparison.InvariantCultureIgnoreCase)))
+            {
+                _logger.LogDebug("skip | download is used by an arr | {name}", download.Name);
+                continue;
+            }
 
             if (!_downloadCleanerConfig.DeletePrivate && download.Private)
             {
@@ -304,107 +280,7 @@ public class DelugeService : DownloadService, IDelugeService
             await _notifier.NotifyDownloadCleaned(download.Ratio, seedingTime, category.Name, result.Reason);
         }
     }
-
-    public override async Task CreateCategoryAsync(string name)
-    {
-        IReadOnlyList<string> existingLabels = await _client.GetLabels();
-
-        if (existingLabels.Contains(name, StringComparer.InvariantCultureIgnoreCase))
-        {
-            return;
-        }
-        
-        await _dryRunInterceptor.InterceptAsync(CreateLabel, name);
-    }
-
-    public override async Task ChangeCategoryForNoHardLinksAsync(List<object>? downloads, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads)
-    {
-        if (downloads?.Count is null or 0)
-        {
-            return;
-        }
-
-        if (!string.IsNullOrEmpty(_downloadCleanerConfig.UnlinkedIgnoredRootDir))
-        {
-            _hardLinkFileService.PopulateFileCounts(_downloadCleanerConfig.UnlinkedIgnoredRootDir);
-        }
-        
-        foreach (TorrentStatus download in downloads.Cast<TorrentStatus>())
-        {
-            if (string.IsNullOrEmpty(download.Hash) || string.IsNullOrEmpty(download.Name) || string.IsNullOrEmpty(download.Label))
-            {
-                continue;
-            }
-            
-            if (excludedHashes.Any(x => x.Equals(download.Hash, StringComparison.InvariantCultureIgnoreCase)))
-            {
-                _logger.LogDebug("skip | download is used by an arr | {name}", download.Name);
-                continue;
-            }
-
-            if (ignoredDownloads.Count > 0 && download.ShouldIgnore(ignoredDownloads))
-            {
-                _logger.LogInformation("skip | download is ignored | {name}", download.Name);
-                continue;
-            }
-        
-            ContextProvider.Set("downloadName", download.Name);
-            ContextProvider.Set("hash", download.Hash);
-            
-            DelugeContents? contents = null;
-            try
-            {
-                contents = await _client.GetTorrentFiles(download.Hash);
-            }
-            catch (Exception exception)
-            {
-                _logger.LogDebug(exception, "failed to find torrent files for {name}", download.Name);
-                continue;
-            }
-            
-            bool hasHardlinks = false;
-            
-            ProcessFiles(contents?.Contents, (_, file) =>
-            {
-                string filePath = string.Join(Path.DirectorySeparatorChar, Path.Combine(download.DownloadLocation, file.Path).Split(['\\', '/']));
-
-                if (file.Priority <= 0)
-                {
-                    _logger.LogDebug("skip | file is not downloaded | {file}", filePath);
-                    return;
-                }
-                
-                long hardlinkCount = _hardLinkFileService.GetHardLinkCount(filePath, !string.IsNullOrEmpty(_downloadCleanerConfig.UnlinkedIgnoredRootDir));
-        
-                if (hardlinkCount < 0)
-                {
-                    _logger.LogDebug("skip | could not get file properties | {file}", filePath);
-                    hasHardlinks = true;
-                    return;
-                }
-        
-                if (hardlinkCount > 0)
-                {
-                    hasHardlinks = true;
-                }
-            });
-            
-            if (hasHardlinks)
-            {
-                _logger.LogDebug("skip | download has hardlinks | {name}", download.Name);
-                continue;
-            }
-            
-            await _dryRunInterceptor.InterceptAsync(ChangeLabel, download.Hash, _downloadCleanerConfig.UnlinkedTargetCategory);
-            
-            _logger.LogInformation("category changed for {name}", download.Name);
-            
-            await _notifier.NotifyCategoryChanged(download.Label, _downloadCleanerConfig.UnlinkedTargetCategory);
-            
-            download.Label = _downloadCleanerConfig.UnlinkedTargetCategory;
-        }
-    }
-
+    
     /// <inheritdoc/>
     [DryRunSafeguard]
     public override async Task DeleteDownload(string hash)
@@ -413,12 +289,6 @@ public class DelugeService : DownloadService, IDelugeService
         
         await _client.DeleteTorrents([hash]);
     }
-
-    [DryRunSafeguard]
-    protected async Task CreateLabel(string name)
-    {
-        await _client.CreateLabel(name);
-    }
     
     [DryRunSafeguard]
     protected virtual async Task ChangeFilesPriority(string hash, List<int> sortedPriorities)
@@ -426,12 +296,6 @@ public class DelugeService : DownloadService, IDelugeService
         await _client.ChangeFilesPriority(hash, sortedPriorities);
     }
     
-    [DryRunSafeguard]
-    protected virtual async Task ChangeLabel(string hash, string newLabel)
-    {
-        await _client.SetTorrentLabel(hash, newLabel);
-    }
-    
     private async Task<(bool, DeleteReason)> IsItemStuckAndShouldRemove(TorrentStatus status)
     {
         if (_queueCleanerConfig.StalledMaxStrikes is 0)

code/Infrastructure/Verticals/DownloadClient/DownloadService.cs

@@ -1,4 +1,4 @@
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 using System.Text.RegularExpressions;
 using Common.Configuration.ContentBlocker;
 using Common.Configuration.DownloadCleaner;
@@ -10,7 +10,6 @@ using Infrastructure.Helpers;
 using Infrastructure.Interceptors;
 using Infrastructure.Verticals.ContentBlocker;
 using Infrastructure.Verticals.Context;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.Notifications;
 using Microsoft.Extensions.Caching.Memory;
@@ -31,7 +30,6 @@ public abstract class DownloadService : IDownloadService
     protected readonly MemoryCacheEntryOptions _cacheOptions;
     protected readonly INotificationPublisher _notifier;
     protected readonly IDryRunInterceptor _dryRunInterceptor;
-    protected readonly IHardLinkFileService _hardLinkFileService;
 
     protected DownloadService(
         ILogger<DownloadService> logger,
@@ -42,8 +40,7 @@ public abstract class DownloadService : IDownloadService
         IFilenameEvaluator filenameEvaluator,
         IStriker striker,
         INotificationPublisher notifier,
-        IDryRunInterceptor dryRunInterceptor,
-        IHardLinkFileService hardLinkFileService
+        IDryRunInterceptor dryRunInterceptor
     )
     {
         _logger = logger;
@@ -55,7 +52,6 @@ public abstract class DownloadService : IDownloadService
         _striker = striker;
         _notifier = notifier;
         _dryRunInterceptor = dryRunInterceptor;
-        _hardLinkFileService = hardLinkFileService;
         _cacheOptions = new MemoryCacheEntryOptions()
             .SetSlidingExpiration(StaticConfiguration.TriggerValue + Constants.CacheLimitBuffer);
     }
@@ -76,23 +72,12 @@ public abstract class DownloadService : IDownloadService
     public abstract Task DeleteDownload(string hash);
 
     /// <inheritdoc/>
-    public abstract Task<List<object>?> GetSeedingDownloads();
-    
-    /// <inheritdoc/>
-    public abstract List<object>? FilterDownloadsToBeCleanedAsync(List<object>? downloads, List<CleanCategory> categories);
+    public abstract Task<List<object>?> GetAllDownloadsToBeCleaned(List<Category> categories);
 
     /// <inheritdoc/>
-    public abstract List<object>? FilterDownloadsToChangeCategoryAsync(List<object>? downloads, List<string> categories);
+    public abstract Task CleanDownloads(List<object> downloads, List<Category> categoriesToClean, HashSet<string> excludedHashes,
+        IReadOnlyList<string> ignoredDownloads);
 
-    /// <inheritdoc/>
-    public abstract Task CleanDownloadsAsync(List<object>? downloads, List<CleanCategory> categoriesToClean, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads);
-
-    /// <inheritdoc/>
-    public abstract Task ChangeCategoryForNoHardLinksAsync(List<object>? downloads, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads);
-    
-    /// <inheritdoc/>
-    public abstract Task CreateCategoryAsync(string name);
-    
     protected void ResetStrikesOnProgress(string hash, long downloaded)
     {
         if (!_queueCleanerConfig.StalledResetStrikesOnProgress)
@@ -122,7 +107,7 @@ public abstract class DownloadService : IDownloadService
         return await _striker.StrikeAndCheckLimit(hash, itemName, _queueCleanerConfig.StalledMaxStrikes, strikeType);
     }
     
-    protected SeedingCheckResult ShouldCleanDownload(double ratio, TimeSpan seedingTime, CleanCategory category)
+    protected SeedingCheckResult ShouldCleanDownload(double ratio, TimeSpan seedingTime, Category category)
     {
         // check ratio
         if (DownloadReachedRatio(ratio, seedingTime, category))
@@ -146,28 +131,8 @@ public abstract class DownloadService : IDownloadService
 
         return new();
     }
-    
-    protected string? GetRootWithFirstDirectory(string path)
-    {
-        if (string.IsNullOrWhiteSpace(path))
-        {
-            return null;
-        }
 
-        string? root = Path.GetPathRoot(path);
-        
-        if (root is null)
-        {
-            return null;
-        }
-
-        string relativePath = path[root.Length..].TrimStart(Path.DirectorySeparatorChar);
-        string[] parts = relativePath.Split(Path.DirectorySeparatorChar, StringSplitOptions.RemoveEmptyEntries);
-
-        return parts.Length > 0 ? Path.Combine(root, parts[0]) : root;
-    }
-    
-    private bool DownloadReachedRatio(double ratio, TimeSpan seedingTime, CleanCategory category)
+    private bool DownloadReachedRatio(double ratio, TimeSpan seedingTime, Category category)
     {
         if (category.MaxRatio < 0)
         {
@@ -193,7 +158,7 @@ public abstract class DownloadService : IDownloadService
         return true;
     }
     
-    private bool DownloadReachedMaxSeedTime(TimeSpan seedingTime, CleanCategory category)
+    private bool DownloadReachedMaxSeedTime(TimeSpan seedingTime, Category category)
     {
         if (category.MaxSeedTime < 0)
         {

code/Infrastructure/Verticals/DownloadClient/DummyDownloadService.cs

@@ -1,11 +1,10 @@
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 using System.Text.RegularExpressions;
 using Common.Configuration.ContentBlocker;
 using Common.Configuration.DownloadCleaner;
 using Common.Configuration.QueueCleaner;
 using Infrastructure.Interceptors;
 using Infrastructure.Verticals.ContentBlocker;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.Notifications;
 using Microsoft.Extensions.Caching.Memory;
@@ -16,21 +15,7 @@ namespace Infrastructure.Verticals.DownloadClient;
 
 public class DummyDownloadService : DownloadService
 {
-    public DummyDownloadService(
-        ILogger<DownloadService> logger,
-        IOptions<QueueCleanerConfig> queueCleanerConfig,
-        IOptions<ContentBlockerConfig> contentBlockerConfig,
-        IOptions<DownloadCleanerConfig> downloadCleanerConfig,
-        IMemoryCache cache,
-        IFilenameEvaluator filenameEvaluator,
-        IStriker striker,
-        INotificationPublisher notifier,
-        IDryRunInterceptor dryRunInterceptor,
-        IHardLinkFileService hardLinkFileService
-    ) : base(
-        logger, queueCleanerConfig, contentBlockerConfig, downloadCleanerConfig,
-        cache, filenameEvaluator, striker, notifier, dryRunInterceptor, hardLinkFileService
-    )
+    public DummyDownloadService(ILogger<DownloadService> logger, IOptions<QueueCleanerConfig> queueCleanerConfig, IOptions<ContentBlockerConfig> contentBlockerConfig, IOptions<DownloadCleanerConfig> downloadCleanerConfig, IMemoryCache cache, IFilenameEvaluator filenameEvaluator, IStriker striker, INotificationPublisher notifier, IDryRunInterceptor dryRunInterceptor) : base(logger, queueCleanerConfig, contentBlockerConfig, downloadCleanerConfig, cache, filenameEvaluator, striker, notifier, dryRunInterceptor)
     {
     }
 
@@ -54,32 +39,13 @@ public class DummyDownloadService : DownloadService
         throw new NotImplementedException();
     }
 
-    public override Task<List<object>?> GetSeedingDownloads()
+    public override Task<List<object>?> GetAllDownloadsToBeCleaned(List<Category> categories)
     {
         throw new NotImplementedException();
     }
 
-    public override List<object>? FilterDownloadsToBeCleanedAsync(List<object>? downloads, List<CleanCategory> categories)
-    {
-        throw new NotImplementedException();
-    }
-
-    public override List<object>? FilterDownloadsToChangeCategoryAsync(List<object>? downloads, List<string> categories)
-    {
-        throw new NotImplementedException();
-    }
-
-    public override Task CleanDownloadsAsync(List<object>? downloads, List<CleanCategory> categoriesToClean, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads)
-    {
-        throw new NotImplementedException();
-    }
-
-    public override Task ChangeCategoryForNoHardLinksAsync(List<object>? downloads, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads)
-    {
-        throw new NotImplementedException();
-    }
-
-    public override Task CreateCategoryAsync(string name)
+    public override Task CleanDownloads(List<object> downloads, List<Category> categoriesToClean, HashSet<string> excludedHashes,
+        IReadOnlyList<string> ignoredDownloads)
     {
         throw new NotImplementedException();
     }

code/Infrastructure/Verticals/DownloadClient/IDownloadService.cs

@@ -34,52 +34,24 @@ public interface IDownloadService : IDisposable
     );
 
     /// <summary>
-    /// Fetches all seeding downloads.
+    /// Fetches all downloads.
     /// </summary>
-    /// <returns>A list of downloads that are seeding.</returns>
-    Task<List<object>?> GetSeedingDownloads();
-
-    /// <summary>
-    /// Filters downloads that should be cleaned.
-    /// </summary>
-    /// <param name="downloads">The downloads to filter.</param>
     /// <param name="categories">The categories by which to filter the downloads.</param>
     /// <returns>A list of downloads for the provided categories.</returns>
-    List<object>? FilterDownloadsToBeCleanedAsync(List<object>? downloads, List<CleanCategory> categories);
-
-    /// <summary>
-    /// Filters downloads that should have their category changed.
-    /// </summary>
-    /// <param name="downloads">The downloads to filter.</param>
-    /// <param name="categories">The categories by which to filter the downloads.</param>
-    /// <returns>A list of downloads for the provided categories.</returns>
-    List<object>? FilterDownloadsToChangeCategoryAsync(List<object>? downloads, List<string> categories);
+    Task<List<object>?> GetAllDownloadsToBeCleaned(List<Category> categories);
 
     /// <summary>
     /// Cleans the downloads.
     /// </summary>
-    /// <param name="downloads">The downloads to clean.</param>
+    /// <param name="downloads"></param>
     /// <param name="categoriesToClean">The categories that should be cleaned.</param>
     /// <param name="excludedHashes">The hashes that should not be cleaned.</param>
-    /// <param name="ignoredDownloads">The downloads to ignore from processing.</param>
-    Task CleanDownloadsAsync(List<object>? downloads, List<CleanCategory> categoriesToClean, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads);
+    /// <param name="ignoredDownloads">Downloads to ignore from processing.</param>
+    public abstract Task CleanDownloads(List<object> downloads, List<Category> categoriesToClean, HashSet<string> excludedHashes,
+        IReadOnlyList<string> ignoredDownloads);
 
-    /// <summary>
-    /// Changes the category for downloads that have no hardlinks.
-    /// </summary>
-    /// <param name="downloads">The downloads to change.</param>
-    /// <param name="excludedHashes">The hashes that should not be cleaned.</param>
-    /// <param name="ignoredDownloads">The downloads to ignore from processing.</param>
-    Task ChangeCategoryForNoHardLinksAsync(List<object>? downloads, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads);
-    
     /// <summary>
     /// Deletes a download item.
     /// </summary>
     public Task DeleteDownload(string hash);
-
-    /// <summary>
-    /// Creates a category.
-    /// </summary>
-    /// <param name="name">The category name.</param>
-    public Task CreateCategoryAsync(string name);
 }

code/Infrastructure/Verticals/DownloadClient/QBittorrent/QBitService.cs

@@ -5,20 +5,19 @@ using Common.Configuration.ContentBlocker;
 using Common.Configuration.DownloadCleaner;
 using Common.Configuration.DownloadClient;
 using Common.Configuration.QueueCleaner;
-using Common.Exceptions;
 using Common.Helpers;
 using Domain.Enums;
 using Infrastructure.Extensions;
 using Infrastructure.Interceptors;
 using Infrastructure.Verticals.ContentBlocker;
 using Infrastructure.Verticals.Context;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.Notifications;
 using Microsoft.Extensions.Caching.Memory;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using QBittorrent.Client;
+using Category = Common.Configuration.DownloadCleaner.Category;
 
 namespace Infrastructure.Verticals.DownloadClient.QBittorrent;
 
@@ -38,11 +37,10 @@ public class QBitService : DownloadService, IQBitService
         IFilenameEvaluator filenameEvaluator,
         IStriker striker,
         INotificationPublisher notifier,
-        IDryRunInterceptor dryRunInterceptor,
-        IHardLinkFileService hardLinkFileService
+        IDryRunInterceptor dryRunInterceptor
     ) : base(
         logger, queueCleanerConfig, contentBlockerConfig, downloadCleanerConfig, cache,
-        filenameEvaluator, striker, notifier, dryRunInterceptor, hardLinkFileService
+        filenameEvaluator, striker, notifier, dryRunInterceptor
     )
     {
         _config = config.Value;
@@ -228,42 +226,20 @@ public class QBitService : DownloadService, IQBitService
     }
     
     /// <inheritdoc/>
-    public override async Task<List<object>?> GetSeedingDownloads() =>
+    public override async Task<List<object>?> GetAllDownloadsToBeCleaned(List<Category> categories) =>
         (await _client.GetTorrentListAsync(new()
         {
             Filter = TorrentListFilter.Seeding
         }))
         ?.Where(x => !string.IsNullOrEmpty(x.Hash))
+        .Where(x => categories.Any(cat => cat.Name.Equals(x.Category, StringComparison.InvariantCultureIgnoreCase)))
         .Cast<object>()
         .ToList();
 
     /// <inheritdoc/>
-    public override List<object>? FilterDownloadsToBeCleanedAsync(List<object>? downloads, List<CleanCategory> categories) =>
-        downloads
-            ?.Cast<TorrentInfo>()
-            .Where(x => !string.IsNullOrEmpty(x.Hash))
-            .Where(x => categories.Any(cat => cat.Name.Equals(x.Category, StringComparison.InvariantCultureIgnoreCase)))
-            .Cast<object>()
-            .ToList();
-
-    /// <inheritdoc/>
-    public override List<object>? FilterDownloadsToChangeCategoryAsync(List<object>? downloads, List<string> categories) =>
-        downloads
-            ?.Cast<TorrentInfo>()
-            .Where(x => !string.IsNullOrEmpty(x.Hash))
-            .Where(x => categories.Any(cat => cat.Equals(x.Category, StringComparison.InvariantCultureIgnoreCase)))
-            .Cast<object>()
-            .ToList();
-
-    /// <inheritdoc/>
-    public override async Task CleanDownloadsAsync(List<object>? downloads, List<CleanCategory> categoriesToClean,
-        HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads)
+    public override async Task CleanDownloads(List<object> downloads, List<Category> categoriesToClean, HashSet<string> excludedHashes,
+        IReadOnlyList<string> ignoredDownloads)
     {
-        if (downloads?.Count is null or 0)
-        {
-            return;
-        }
-        
         foreach (TorrentInfo download in downloads)
         {
             if (string.IsNullOrEmpty(download.Hash))
@@ -271,22 +247,16 @@ public class QBitService : DownloadService, IQBitService
                 continue;
             }
             
-            if (excludedHashes.Any(x => x.Equals(download.Hash, StringComparison.InvariantCultureIgnoreCase)))
-            {
-                _logger.LogDebug("skip | download is used by an arr | {name}", download.Name);
-                continue;
-            }
-            
             IReadOnlyList<TorrentTracker> trackers = await GetTrackersAsync(download.Hash);
 
             if (ignoredDownloads.Count > 0 &&
-                (download.ShouldIgnore(ignoredDownloads) || trackers.Any(x => x.ShouldIgnore(ignoredDownloads))))
+                (download.ShouldIgnore(ignoredDownloads) || trackers.Any(x => x.ShouldIgnore(ignoredDownloads)) is true))
             {
                 _logger.LogInformation("skip | download is ignored | {name}", download.Name);
                 continue;
             }
             
-            CleanCategory? category = categoriesToClean
+            Category? category = categoriesToClean
                 .FirstOrDefault(x => download.Category.Equals(x.Name, StringComparison.InvariantCultureIgnoreCase));
             
             if (category is null)
@@ -294,6 +264,12 @@ public class QBitService : DownloadService, IQBitService
                 continue;
             }
             
+            if (excludedHashes.Any(x => x.Equals(download.Hash, StringComparison.InvariantCultureIgnoreCase)))
+            {
+                _logger.LogDebug("skip | download is used by an arr | {name}", download.Name);
+                continue;
+            }
+            
             if (!_downloadCleanerConfig.DeletePrivate)
             {
                 TorrentProperties? torrentProperties = await _client.GetTorrentPropertiesAsync(download.Hash);
@@ -339,125 +315,12 @@ public class QBitService : DownloadService, IQBitService
         }
     }
 
-    public override async Task CreateCategoryAsync(string name)
-    {
-        IReadOnlyDictionary<string, Category>? existingCategories = await _client.GetCategoriesAsync();
-        
-        if (existingCategories.Any(x => x.Value.Name.Equals(name, StringComparison.InvariantCultureIgnoreCase)))
-        {
-            return;
-        }
-        
-        await _dryRunInterceptor.InterceptAsync(CreateCategory, name);
-    }
-
-    public override async Task ChangeCategoryForNoHardLinksAsync(List<object>? downloads, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads)
-    {
-        if (downloads?.Count is null or 0)
-        {
-            return;
-        }
-        
-        if (!string.IsNullOrEmpty(_downloadCleanerConfig.UnlinkedIgnoredRootDir))
-        {
-            _hardLinkFileService.PopulateFileCounts(_downloadCleanerConfig.UnlinkedIgnoredRootDir);
-        }
-        
-        foreach (TorrentInfo download in downloads)
-        {
-            if (string.IsNullOrEmpty(download.Hash))
-            {
-                continue;
-            }
-            
-            if (excludedHashes.Any(x => x.Equals(download.Hash, StringComparison.InvariantCultureIgnoreCase)))
-            {
-                _logger.LogDebug("skip | download is used by an arr | {name}", download.Name);
-                continue;
-            }
-            
-            IReadOnlyList<TorrentTracker> trackers = await GetTrackersAsync(download.Hash);
-            
-            if (ignoredDownloads.Count > 0 &&
-                (download.ShouldIgnore(ignoredDownloads) || trackers.Any(x => x.ShouldIgnore(ignoredDownloads))))
-            {
-                _logger.LogInformation("skip | download is ignored | {name}", download.Name);
-                continue;
-            }
-            
-            IReadOnlyList<TorrentContent>? files = await _client.GetTorrentContentsAsync(download.Hash);
-
-            if (files is null)
-            {
-                _logger.LogDebug("failed to find files for {name}", download.Name);
-                continue;
-            }
-
-            ContextProvider.Set("downloadName", download.Name);
-            ContextProvider.Set("hash", download.Hash);
-            bool hasHardlinks = false;
-            
-            foreach (TorrentContent file in files)
-            {
-                if (!file.Index.HasValue)
-                {
-                    _logger.LogDebug("skip | file index is null for {name}", download.Name);
-                    hasHardlinks = true;
-                    break;
-                }
-
-                string filePath = string.Join(Path.DirectorySeparatorChar, Path.Combine(download.SavePath, file.Name).Split(['\\', '/']));
-
-                if (file.Priority is TorrentContentPriority.Skip)
-                {
-                    _logger.LogDebug("skip | file is not downloaded | {file}", filePath);
-                    continue;
-                }
-                
-                long hardlinkCount = _hardLinkFileService.GetHardLinkCount(filePath, !string.IsNullOrEmpty(_downloadCleanerConfig.UnlinkedIgnoredRootDir));
-
-                if (hardlinkCount < 0)
-                {
-                    _logger.LogDebug("skip | could not get file properties | {file}", filePath);
-                    hasHardlinks = true;
-                    break;
-                }
-
-                if (hardlinkCount > 0)
-                {
-                    hasHardlinks = true;
-                    break;
-                }
-            }
-            
-            if (hasHardlinks)
-            {
-                _logger.LogDebug("skip | download has hardlinks | {name}", download.Name);
-                continue;
-            }
-            
-            await _dryRunInterceptor.InterceptAsync(ChangeCategory, download.Hash, _downloadCleanerConfig.UnlinkedTargetCategory);
-            
-            _logger.LogInformation("category changed for {name}", download.Name);
-            
-            await _notifier.NotifyCategoryChanged(download.Category, _downloadCleanerConfig.UnlinkedTargetCategory);
-            
-            download.Category = _downloadCleanerConfig.UnlinkedTargetCategory;
-        }
-    }
-    
     /// <inheritdoc/>
     [DryRunSafeguard]
     public override async Task DeleteDownload(string hash)
     {
         await _client.DeleteAsync(hash, deleteDownloadedData: true);
     }
-
-    [DryRunSafeguard]
-    protected async Task CreateCategory(string name)
-    {
-        await _client.AddCategoryAsync(name);
-    }
     
     [DryRunSafeguard]
     protected virtual async Task SkipFile(string hash, int fileIndex)
@@ -465,12 +328,6 @@ public class QBitService : DownloadService, IQBitService
         await _client.SetFilePriorityAsync(hash, fileIndex, TorrentContentPriority.Skip);
     }
 
-    [DryRunSafeguard]
-    protected virtual async Task ChangeCategory(string hash, string newCategory)
-    {
-        await _client.SetTorrentCategoryAsync([hash], newCategory);
-    }
-
     public override void Dispose()
     {
         _client.Dispose();
@@ -478,33 +335,39 @@ public class QBitService : DownloadService, IQBitService
 
     private async Task<(bool, DeleteReason)> IsItemStuckAndShouldRemove(TorrentInfo torrent, bool isPrivate)
     {
-        if (_queueCleanerConfig.StalledMaxStrikes is 0)
+        if (_queueCleanerConfig.StalledMaxStrikes is 0 && _queueCleanerConfig.DownloadingMetadataMaxStrikes is 0)
         {
-            return (false, default);
-        }
-        
-        if (_queueCleanerConfig.StalledIgnorePrivate && isPrivate)
-        {
-            // ignore private trackers
-            _logger.LogDebug("skip stalled check | download is private | {name}", torrent.Name);
-            return (false, default);
+            return (false, DeleteReason.None);
         }
         
         if (torrent.State is not TorrentState.StalledDownload and not TorrentState.FetchingMetadata
             and not TorrentState.ForcedFetchingMetadata)
         {
             // ignore other states
-            return (false, default);
+            return (false, DeleteReason.None);
         }
 
-        ResetStrikesOnProgress(torrent.Hash, torrent.Downloaded ?? 0);
-
-        if (torrent.State is TorrentState.StalledDownload)
+        if (_queueCleanerConfig.StalledMaxStrikes > 0 && torrent.State is TorrentState.StalledDownload)
         {
-            return (await StrikeAndCheckLimit(torrent.Hash, torrent.Name, StrikeType.Stalled), DeleteReason.Stalled);
+            if (_queueCleanerConfig.StalledIgnorePrivate && isPrivate)
+            {
+                // ignore private trackers
+                _logger.LogDebug("skip stalled check | download is private | {name}", torrent.Name);
+            }
+            else
+            {
+                ResetStrikesOnProgress(torrent.Hash, torrent.Downloaded ?? 0);
+            
+                return (await StrikeAndCheckLimit(torrent.Hash, torrent.Name, StrikeType.Stalled), DeleteReason.Stalled);
+            }
         }
 
-        return (await StrikeAndCheckLimit(torrent.Hash, torrent.Name, StrikeType.DownloadingMetadata), DeleteReason.DownloadingMetadata);
+        if (_queueCleanerConfig.DownloadingMetadataMaxStrikes > 0)
+        {
+            return (await StrikeAndCheckLimit(torrent.Hash, torrent.Name, StrikeType.DownloadingMetadata), DeleteReason.DownloadingMetadata);
+        }
+
+        return (false, DeleteReason.None);
     }
 
     private async Task<IReadOnlyList<TorrentTracker>> GetTrackersAsync(string hash)

code/Infrastructure/Verticals/DownloadClient/Transmission/TransmissionService.cs

@@ -5,14 +5,12 @@ using Common.Configuration.ContentBlocker;
 using Common.Configuration.DownloadCleaner;
 using Common.Configuration.DownloadClient;
 using Common.Configuration.QueueCleaner;
-using Common.Exceptions;
 using Common.Helpers;
 using Domain.Enums;
 using Infrastructure.Extensions;
 using Infrastructure.Interceptors;
 using Infrastructure.Verticals.ContentBlocker;
 using Infrastructure.Verticals.Context;
-using Infrastructure.Verticals.Files;
 using Infrastructure.Verticals.ItemStriker;
 using Infrastructure.Verticals.Notifications;
 using Microsoft.Extensions.Caching.Memory;
@@ -28,6 +26,7 @@ public class TransmissionService : DownloadService, ITransmissionService
 {
     private readonly TransmissionConfig _config;
     private readonly Client _client;
+    private TorrentInfo[]? _torrentsCache;
 
     private static readonly string[] Fields =
     [
@@ -57,11 +56,10 @@ public class TransmissionService : DownloadService, ITransmissionService
         IFilenameEvaluator filenameEvaluator,
         IStriker striker,
         INotificationPublisher notifier,
-        IDryRunInterceptor dryRunInterceptor,
-        IHardLinkFileService hardLinkFileService
+        IDryRunInterceptor dryRunInterceptor
     ) : base(
         logger, queueCleanerConfig, contentBlockerConfig, downloadCleanerConfig, cache,
-        filenameEvaluator, striker, notifier, dryRunInterceptor, hardLinkFileService
+        filenameEvaluator, striker, notifier, dryRunInterceptor
     )
     {
         _config = config.Value;
@@ -211,38 +209,14 @@ public class TransmissionService : DownloadService, ITransmissionService
 
         return result;
     }
-    
-    public override async Task<List<object>?> GetSeedingDownloads()
-    {
-        string[] fields = [
-            TorrentFields.FILES,
-            TorrentFields.FILE_STATS,
-            TorrentFields.HASH_STRING,
-            TorrentFields.ID,
-            TorrentFields.ETA,
-            TorrentFields.NAME,
-            TorrentFields.STATUS,
-            TorrentFields.IS_PRIVATE,
-            TorrentFields.DOWNLOADED_EVER,
-            TorrentFields.DOWNLOAD_DIR,
-            TorrentFields.SECONDS_SEEDING,
-            TorrentFields.UPLOAD_RATIO
-        ];
 
-        return (await _client.TorrentGetAsync(fields))
+    /// <inheritdoc/>
+    public override async Task<List<object>?> GetAllDownloadsToBeCleaned(List<Category> categories)
+    {
+        return (await _client.TorrentGetAsync(Fields))
             ?.Torrents
             ?.Where(x => !string.IsNullOrEmpty(x.HashString))
             .Where(x => x.Status is 5 or 6)
-            .Cast<object>()
-            .ToList();
-    }
-
-    /// <inheritdoc/>
-    public override List<object>? FilterDownloadsToBeCleanedAsync(List<object>? downloads, List<CleanCategory> categories)
-    {
-        return downloads
-            ?
-            .Cast<TorrentInfo>()
             .Where(x => categories
                 .Any(cat =>
                 {
@@ -259,20 +233,10 @@ public class TransmissionService : DownloadService, ITransmissionService
             .ToList();
     }
 
-    public override List<object>? FilterDownloadsToChangeCategoryAsync(List<object>? downloads, List<string> categories)
-    {
-        throw new NotImplementedException();
-    }
-
     /// <inheritdoc/>
-    public override async Task CleanDownloadsAsync(List<object>? downloads, List<CleanCategory> categoriesToClean,
-        HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads)
+    public override async Task CleanDownloads(List<object> downloads, List<Category> categoriesToClean, HashSet<string> excludedHashes,
+        IReadOnlyList<string> ignoredDownloads)
     {
-        if (downloads?.Count is null or 0)
-        {
-            return;
-        }
-        
         foreach (TorrentInfo download in downloads)
         {
             if (string.IsNullOrEmpty(download.HashString))
@@ -286,7 +250,7 @@ public class TransmissionService : DownloadService, ITransmissionService
                 continue;
             }
             
-            CleanCategory? category = categoriesToClean
+            Category? category = categoriesToClean
                 .FirstOrDefault(x =>
                 {
                     if (download.DownloadDir is null)
@@ -340,138 +304,6 @@ public class TransmissionService : DownloadService, ITransmissionService
         }
     }
     
-    public override async Task CreateCategoryAsync(string name)
-    {
-        throw new NotImplementedException();
-    }
-
-    public override async Task ChangeCategoryForNoHardLinksAsync(List<object>? downloads, HashSet<string> excludedHashes, IReadOnlyList<string> ignoredDownloads)
-    {
-        if (downloads?.Count is null or 0)
-        {
-            return;
-        }
-        
-        // TODO ignored downloads
-        throw new NotImplementedException();
-        
-        // if (_downloadCleanerConfig.NoHardLinksIgnoreRootDir)
-        // {
-        //     downloads
-        //         .Cast<TorrentInfo>()
-        //         .Select(x =>
-        //         {
-        //             if (x.DownloadDir == null)
-        //             {
-        //                 return string.Empty;
-        //             }
-        //             
-        //             string? firstDir = GetRootWithFirstDirectory(x.DownloadDir);
-        //
-        //             if (string.IsNullOrEmpty(firstDir))
-        //             {
-        //                 return string.Empty;
-        //             }
-        //
-        //             if (firstDir == Path.GetPathRoot(x.DownloadDir))
-        //             {
-        //                 return string.Empty;
-        //             }
-        //             
-        //             return firstDir;
-        //         })
-        //         .Where(x => !string.IsNullOrEmpty(x))
-        //         .Distinct()
-        //         .ToList()
-        //         .ForEach(x =>
-        //         {
-        //             _logger.LogTrace("populating file counts from {dir}", x);
-        //             
-        //             if (!Directory.Exists(x))
-        //             {
-        //                 throw new ValidationException($"directory \"{x}\" does not exist");
-        //             }
-        //             
-        //             _hardLinkFileService.PopulateFileCounts(x);
-        //         });
-        // }
-        //
-        // foreach (TorrentInfo download in downloads.Cast<TorrentInfo>())
-        // {
-        //     if (string.IsNullOrEmpty(download.HashString) || download.DownloadDir == null)
-        //     {
-        //         _logger.LogDebug("skip | download hash or download directory is null for {name}", download.Name);
-        //         continue;
-        //     }
-        //     
-        //     if (excludedHashes.Any(x => x.Equals(download.HashString, StringComparison.InvariantCultureIgnoreCase)))
-        //     {
-        //         _logger.LogDebug("skip | download is used by an arr | {name}", download.Name);
-        //         continue;
-        //     }
-        //
-        //     ContextProvider.Set("downloadName", download.Name);
-        //     ContextProvider.Set("hash", download.HashString);
-        //     
-        //     bool hasHardlinks = false;
-        //     
-        //     if (download.Files != null)
-        //     {
-        //         foreach (TransmissionTorrentFiles file in download.Files)
-        //         {
-        //             string filePath = Path.Combine(download.DownloadDir, file.Name);
-        //             
-        //             long hardlinkCount = _hardLinkFileService.GetHardLinkCount(filePath, _downloadCleanerConfig.NoHardLinksIgnoreRootDir);
-        //
-        //             if (hardlinkCount < 0)
-        //             {
-        //                 _logger.LogDebug("skip | could not get file properties | {name}", download.Name);
-        //                 hasHardlinks = true;
-        //                 break;
-        //             }
-        //
-        //             if (hardlinkCount > 0)
-        //             {
-        //                 hasHardlinks = true;
-        //                 break;
-        //             }
-        //         }
-        //     }
-        //     
-        //     if (hasHardlinks)
-        //     {
-        //         _logger.LogDebug("skip | download has hardlinks | {name}", download.Name);
-        //         continue;
-        //     }
-        //     
-        //     // Get the current category (directory name)
-        //     string currentCategory = Path.GetFileName(Path.TrimEndingDirectorySeparator(download.DownloadDir));
-        //     
-        //     // Create the new location path
-        //     string newLocation = Path.Combine(
-        //         Path.GetDirectoryName(Path.TrimEndingDirectorySeparator(download.DownloadDir)) ?? string.Empty,
-        //         _downloadCleanerConfig.NoHardLinksCategory
-        //     );
-        //     
-        //     await _dryRunInterceptor.InterceptAsync(MoveDownload, download.Id, newLocation);
-        //     
-        //     _logger.LogInformation("category changed for {name}", download.Name);
-        //     
-        //     await _notifier.NotifyCategoryChanged(currentCategory, _downloadCleanerConfig.NoHardLinksCategory);
-        // }
-    }
-
-    [DryRunSafeguard]
-    protected virtual async Task MoveDownload(long downloadId, string newLocation)
-    {
-        await _client.TorrentSetAsync(new TorrentSettings
-        {
-            Ids = [downloadId],
-            Location = newLocation,
-            // Move = true
-        });
-    }
-
     public override async Task DeleteDownload(string hash)
     {
         TorrentInfo? torrent = await GetTorrentAsync(hash);
@@ -534,8 +366,30 @@ public class TransmissionService : DownloadService, ITransmissionService
         return (await StrikeAndCheckLimit(torrent.HashString!, torrent.Name!, StrikeType.Stalled), DeleteReason.Stalled);
     }
 
-    private async Task<TorrentInfo?> GetTorrentAsync(string hash) =>
-        (await _client.TorrentGetAsync(Fields, hash))
-        ?.Torrents
-        ?.FirstOrDefault();
+    private async Task<TorrentInfo?> GetTorrentAsync(string hash)
+    {
+        TorrentInfo? torrent = _torrentsCache?
+            .FirstOrDefault(x => x.HashString.Equals(hash, StringComparison.InvariantCultureIgnoreCase));
+        
+        if (_torrentsCache is null || torrent is null)
+        {
+            // refresh cache
+            _torrentsCache = (await _client.TorrentGetAsync(Fields))
+                ?.Torrents;
+        }
+        
+        if (_torrentsCache?.Length is null or 0)
+        {
+            _logger.LogDebug("could not list torrents | {url}", _config.Url);
+        }
+        
+        torrent = _torrentsCache?.FirstOrDefault(x => x.HashString.Equals(hash, StringComparison.InvariantCultureIgnoreCase));
+
+        if (torrent is null)
+        {
+            _logger.LogDebug("could not find torrent | {hash} | {url}", hash, _config.Url);
+        }
+
+        return torrent;
+    }
 }

code/Infrastructure/Verticals/Files/HardLinkFileService.cs

@@ -1,51 +0,0 @@
-using System.Runtime.InteropServices;
-using Microsoft.Extensions.Logging;
-
-namespace Infrastructure.Verticals.Files;
-
-public class HardLinkFileService : IHardLinkFileService
-{
-    private readonly ILogger<HardLinkFileService> _logger;
-    private readonly UnixHardLinkFileService _unixHardLinkFileService;
-    private readonly WindowsHardLinkFileService _windowsHardLinkFileService;
-
-    public HardLinkFileService(
-        ILogger<HardLinkFileService> logger,
-        UnixHardLinkFileService unixHardLinkFileService,
-        WindowsHardLinkFileService windowsHardLinkFileService
-    )
-    {
-        _logger = logger;
-        _unixHardLinkFileService = unixHardLinkFileService;
-        _windowsHardLinkFileService = windowsHardLinkFileService;
-    }
-
-    public void PopulateFileCounts(string directoryPath)
-    {
-        _logger.LogTrace("populating file counts from {dir}", directoryPath);
-        
-        if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-        {
-            _windowsHardLinkFileService.PopulateFileCounts(directoryPath);
-            return;
-        }
-        
-        _unixHardLinkFileService.PopulateFileCounts(directoryPath);
-    }
-
-    public long GetHardLinkCount(string filePath, bool ignoreRootDir)
-    {
-        if (!File.Exists(filePath))
-        {
-            _logger.LogDebug("file {file} does not exist", filePath);
-            return -1;
-        }
-        
-        if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-        {
-            return _windowsHardLinkFileService.GetHardLinkCount(filePath, ignoreRootDir);
-        }
-
-        return _unixHardLinkFileService.GetHardLinkCount(filePath, ignoreRootDir);
-    }
-}

code/Infrastructure/Verticals/Files/IHardLinkFileService.cs

@@ -1,19 +0,0 @@
-namespace Infrastructure.Verticals.Files;
-
-public interface IHardLinkFileService
-{
-    /// <summary>
-    /// Populates the inode counts for Unix and the file index counts for Windows.
-    /// Needs to be called before <see cref="GetHardLinkCount"/> to populate the inode counts.
-    /// </summary>
-    /// <param name="directoryPath">The root directory where to search for hardlinks.</param>
-    void PopulateFileCounts(string directoryPath);
-    
-    /// <summary>
-    /// Get the hardlink count of a file.
-    /// </summary>
-    /// <param name="filePath">File path.</param>
-    /// <param name="ignoreRootDir">Whether to ignore hardlinks found in the same root dir.</param>
-    /// <returns>-1 on error, 0 if there are no hardlinks and 1 otherwise.</returns>
-    long GetHardLinkCount(string filePath, bool ignoreRootDir);
-}

code/Infrastructure/Verticals/Files/UnixHardLinkFileService.cs

@@ -1,87 +0,0 @@
-using System.Collections.Concurrent;
-using Microsoft.Extensions.Logging;
-using Mono.Unix.Native;
-
-namespace Infrastructure.Verticals.Files;
-
-public class UnixHardLinkFileService : IHardLinkFileService, IDisposable
-{
-    private readonly ILogger<UnixHardLinkFileService> _logger;
-    private readonly ConcurrentDictionary<ulong, int> _inodeCounts = new();
-    
-    public UnixHardLinkFileService(ILogger<UnixHardLinkFileService> logger)
-    {
-        _logger = logger;
-    }
-    
-    /// <inheritdoc/>
-    public long GetHardLinkCount(string filePath, bool ignoreRootDir)
-    {
-        try
-        {
-            if (Syscall.stat(filePath, out Stat stat) != 0)
-            {
-                _logger.LogDebug("failed to stat file {file}", filePath);
-                return -1;
-            }
-
-            if (!ignoreRootDir)
-            {
-                _logger.LogDebug("stat file | hardlinks: {nlink} | {file}", stat.st_nlink, filePath);
-                return (long)stat.st_nlink == 1 ? 0 : 1;
-            }
-
-            // get the number of hardlinks in the same root directory
-            int linksInIgnoredDir = _inodeCounts.TryGetValue(stat.st_ino, out int count) 
-                ? count
-                : 1; // default to 1 if not found
-            
-            _logger.LogDebug("stat file | hardlinks: {nlink} | ignored: {ignored} | {file}", stat.st_nlink, linksInIgnoredDir, filePath);
-            return (long)stat.st_nlink - linksInIgnoredDir;
-        }
-        catch (Exception exception)
-        {
-            _logger.LogError(exception, "failed to stat file {file}", filePath);
-            return -1;
-        }
-    }
-    
-    /// <inheritdoc/>
-    public void PopulateFileCounts(string directoryPath)
-    {
-        try
-        {
-            // traverse all files in the ignored path and subdirectories
-            foreach (string file in Directory.EnumerateFiles(directoryPath, "*", SearchOption.AllDirectories))
-            {
-                AddInodeToCount(file);
-            }
-        }
-        catch (Exception ex)
-        {
-            _logger.LogError(ex, "failed to populate inode counts from {dir}", directoryPath);
-            throw;
-        }
-    }
-
-    private void AddInodeToCount(string path)
-    {
-        try
-        {
-            if (Syscall.stat(path, out Stat stat) == 0)
-            {
-                _inodeCounts.AddOrUpdate(stat.st_ino, 1, (_, count) => count + 1);
-            }
-        }
-        catch (Exception ex)
-        {
-            _logger.LogWarning(ex, "could not stat {path} during inode counting", path);
-            throw;
-        }
-    }
-
-    public void Dispose()
-    {
-        _inodeCounts.Clear();
-    }
-}

code/Infrastructure/Verticals/Files/WindowsHardLinkFileService.cs

@@ -1,113 +0,0 @@
-using System.Collections.Concurrent;
-using System.Runtime.InteropServices;
-using Microsoft.Extensions.Logging;
-using Microsoft.Win32.SafeHandles;
-
-namespace Infrastructure.Verticals.Files;
-
-public class WindowsHardLinkFileService : IHardLinkFileService, IDisposable
-{
-    private readonly ILogger<WindowsHardLinkFileService> _logger;
-    private readonly ConcurrentDictionary<ulong, int> _fileIndexCounts = new();
-
-    public WindowsHardLinkFileService(ILogger<WindowsHardLinkFileService> logger)
-    {
-        _logger = logger;
-    }
-    
-    /// <inheritdoc/>
-    public long GetHardLinkCount(string filePath, bool ignoreRootDir)
-    {
-        try
-        {
-            using SafeFileHandle fileStream = File.OpenHandle(filePath);
-
-            if (!GetFileInformationByHandle(fileStream, out var file))
-            {
-                _logger.LogDebug("failed to get file handle {file}", filePath);
-                return -1;
-            }
-
-            if (!ignoreRootDir)
-            {
-                _logger.LogDebug("stat file | hardlinks: {nlink} | {file}", file.NumberOfLinks, filePath);
-                return file.NumberOfLinks == 1 ? 0 : 1;
-            }
-
-            // Get unique file ID (combination of high and low indices)
-            ulong fileIndex = ((ulong)file.FileIndexHigh << 32) | file.FileIndexLow;
-            
-            // get the number of hardlinks in the same root directory
-            int linksInIgnoredDir = _fileIndexCounts.TryGetValue(fileIndex, out int count)
-                ? count
-                : 1; // default to 1 if not found
-
-            _logger.LogDebug("stat file | hardlinks: {links} | ignored: {ignored} | {file}", file.NumberOfLinks, linksInIgnoredDir, filePath);
-            return file.NumberOfLinks - linksInIgnoredDir;
-        }
-        catch (Exception exception)
-        {
-            _logger.LogError(exception, "failed to stat file {file}", filePath);
-            return -1;
-        }
-    }
-
-    /// <inheritdoc/>
-    public void PopulateFileCounts(string directoryPath)
-    {
-        try
-        {
-            // traverse all files in the ignored path and subdirectories
-            foreach (string file in Directory.EnumerateFiles(directoryPath, "*", SearchOption.AllDirectories))
-            {
-                AddFileIndexToCount(file);
-            }
-        }
-        catch (Exception ex)
-        {
-            _logger.LogError(ex, "Failed to populate file index counts from {dir}", directoryPath);
-        }
-    }
-
-    private void AddFileIndexToCount(string path)
-    {
-        try
-        {
-            using SafeFileHandle fileStream = File.OpenHandle(path);
-            if (GetFileInformationByHandle(fileStream, out var file))
-            {
-                ulong fileIndex = ((ulong)file.FileIndexHigh << 32) | file.FileIndexLow;
-                _fileIndexCounts.AddOrUpdate(fileIndex, 1, (_, count) => count + 1);
-            }
-        }
-        catch (Exception ex)
-        {
-            _logger.LogWarning(ex, "Couldn't stat {path} during file index counting", path);
-        }
-    }
-
-    [DllImport("kernel32.dll", SetLastError = true)]
-    private static extern bool GetFileInformationByHandle(
-        SafeFileHandle hFile,
-        out BY_HANDLE_FILE_INFORMATION lpFileInformation
-    );
-
-    private struct BY_HANDLE_FILE_INFORMATION
-    {
-        public uint FileAttributes;
-        public System.Runtime.InteropServices.ComTypes.FILETIME CreationTime;
-        public System.Runtime.InteropServices.ComTypes.FILETIME LastAccessTime;
-        public System.Runtime.InteropServices.ComTypes.FILETIME LastWriteTime;
-        public uint VolumeSerialNumber;
-        public uint FileSizeHigh;
-        public uint FileSizeLow;
-        public uint NumberOfLinks;
-        public uint FileIndexHigh;
-        public uint FileIndexLow;
-    }
-    
-    public void Dispose()
-    {
-        _fileIndexCounts.Clear();
-    }
-}

code/Infrastructure/Verticals/Notifications/Consumers/NotificationConsumer.cs

@@ -33,9 +33,6 @@ public sealed class NotificationConsumer<T> : IConsumer<T> where T : Notificatio
                 case DownloadCleanedNotification downloadCleanedNotification:
                     await _notificationService.Notify(downloadCleanedNotification);
                     break;
-                case CategoryChangedNotification categoryChangedNotification:
-                    await _notificationService.Notify(categoryChangedNotification);
-                    break;
                 default:
                     throw new NotImplementedException();
             }

code/Infrastructure/Verticals/Notifications/INotificationFactory.cs

@@ -9,6 +9,4 @@ public interface INotificationFactory
     List<INotificationProvider> OnQueueItemDeletedEnabled();
 
     List<INotificationProvider> OnDownloadCleanedEnabled();
-    
-    List<INotificationProvider> OnCategoryChangedEnabled();
 }

code/Infrastructure/Verticals/Notifications/INotificationProvider.cs

@@ -16,6 +16,4 @@ public interface INotificationProvider
     Task OnQueueItemDeleted(QueueItemDeletedNotification notification);
 
     Task OnDownloadCleaned(DownloadCleanedNotification notification);
-    
-    Task OnCategoryChanged(CategoryChangedNotification notification);
 }

code/Infrastructure/Verticals/Notifications/INotificationPublisher.cs

@@ -9,6 +9,4 @@ public interface INotificationPublisher
     Task NotifyQueueItemDeleted(bool removeFromClient, DeleteReason reason);
     
     Task NotifyDownloadCleaned(double ratio, TimeSpan seedingTime, string categoryName, CleanReason reason);
-
-    Task NotifyCategoryChanged(string oldCategory, string newCategory);
 }

code/Infrastructure/Verticals/Notifications/Models/CategoryChangedNotification.cs

@@ -1,5 +0,0 @@
-namespace Infrastructure.Verticals.Notifications.Models;
-
-public sealed record CategoryChangedNotification : Notification
-{
-}

code/Infrastructure/Verticals/Notifications/Notifiarr/NotifiarrProvider.cs

@@ -41,11 +41,6 @@ public class NotifiarrProvider : NotificationProvider
     {
         await _proxy.SendNotification(BuildPayload(notification), _config);
     }
-    
-    public override async Task OnCategoryChanged(CategoryChangedNotification notification)
-    {
-        await _proxy.SendNotification(BuildPayload(notification), _config);
-    }
 
     private NotifiarrPayload BuildPayload(ArrNotification notification, string color)
     {
@@ -110,32 +105,4 @@ public class NotifiarrProvider : NotificationProvider
         
         return payload;
     }
-
-    private NotifiarrPayload BuildPayload(CategoryChangedNotification notification)
-    {
-        NotifiarrPayload payload = new()
-        {
-            Discord = new()
-            {
-                Color = WarningColor,
-                Text = new()
-                {
-                    Title = notification.Title,
-                    Icon = Logo,
-                    Description = notification.Description,
-                    Fields = notification.Fields?.Adapt<List<Field>>() ?? []
-                },
-                Ids = new Ids
-                {
-                    Channel = _config.ChannelId
-                },
-                Images = new()
-                {
-                    Thumbnail = new Uri(Logo)
-                }
-            }
-        };
-        
-        return payload;
-    }
 }

code/Infrastructure/Verticals/Notifications/Notifiarr/NotifiarrProxy.cs

@@ -1,6 +1,5 @@
 using System.Text;
 using Common.Helpers;
-using Microsoft.Extensions.Logging;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Serialization;
 
@@ -8,14 +7,12 @@ namespace Infrastructure.Verticals.Notifications.Notifiarr;
 
 public class NotifiarrProxy : INotifiarrProxy
 {
-    private readonly ILogger<NotifiarrProxy> _logger;
     private readonly HttpClient _httpClient;
 
     private const string Url = "https://notifiarr.com/api/v1/notification/passthrough/";
 
-    public NotifiarrProxy(ILogger<NotifiarrProxy> logger, IHttpClientFactory httpClientFactory)
+    public NotifiarrProxy(IHttpClientFactory httpClientFactory)
     {
-        _logger = logger;
         _httpClient = httpClientFactory.CreateClient(Constants.HttpClientWithRetryName);
     }
 
@@ -28,8 +25,6 @@ public class NotifiarrProxy : INotifiarrProxy
                 ContractResolver = new CamelCasePropertyNamesContractResolver()
             });
             
-            _logger.LogTrace("sending notification to Notifiarr: {content}", content);
-            
             using HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Post, $"{Url}{config.ApiKey}");
             request.Method = HttpMethod.Post;
             request.Content = new StringContent(content, Encoding.UTF8, "application/json");

code/Infrastructure/Verticals/Notifications/NotificationFactory.cs

@@ -34,9 +34,4 @@ public class NotificationFactory : INotificationFactory
         ActiveProviders()
             .Where(n => n.Config.OnDownloadCleaned)
             .ToList();
-    
-    public List<INotificationProvider> OnCategoryChangedEnabled() =>
-        ActiveProviders()
-            .Where(n => n.Config.OnCategoryChanged)
-            .ToList();
 }

code/Infrastructure/Verticals/Notifications/NotificationProvider.cs

@@ -22,6 +22,4 @@ public abstract class NotificationProvider : INotificationProvider
     public abstract Task OnQueueItemDeleted(QueueItemDeletedNotification notification);
 
     public abstract Task OnDownloadCleaned(DownloadCleanedNotification notification);
-    
-    public abstract Task OnCategoryChanged(CategoryChangedNotification notification);
 }

code/Infrastructure/Verticals/Notifications/NotificationPublisher.cs

@@ -48,10 +48,10 @@ public class NotificationPublisher : INotificationPublisher
             switch (strikeType)
             {
                 case StrikeType.Stalled:
-                    await NotifyInternal(notification.Adapt<StalledStrikeNotification>());
+                    await _dryRunInterceptor.InterceptAsync(Notify<StalledStrikeNotification>, notification.Adapt<StalledStrikeNotification>());
                     break;
                 case StrikeType.ImportFailed:
-                    await NotifyInternal(notification.Adapt<FailedImportStrikeNotification>());
+                    await _dryRunInterceptor.InterceptAsync(Notify<FailedImportStrikeNotification>, notification.Adapt<FailedImportStrikeNotification>());
                     break;
             }
         }
@@ -81,7 +81,7 @@ public class NotificationPublisher : INotificationPublisher
                 Fields = [new() { Title = "Removed from download client?", Text = removeFromClient ? "Yes" : "No" }]
             };
 
-            await NotifyInternal(notification);
+            await _dryRunInterceptor.InterceptAsync(Notify<QueueItemDeletedNotification>, notification);
         }
         catch (Exception ex)
         {
@@ -110,36 +110,13 @@ public class NotificationPublisher : INotificationPublisher
                 Level = NotificationLevel.Important
             };
 
-            await NotifyInternal(notification);
+            await _dryRunInterceptor.InterceptAsync(Notify<DownloadCleanedNotification>, notification);
         }
         catch (Exception ex)
         {
             _logger.LogError(ex, "failed to notify download cleaned");
         }
     }
-    
-    public virtual async Task NotifyCategoryChanged(string oldCategory, string newCategory)
-    {
-        CategoryChangedNotification notification = new()
-        {
-            Title = "Category changed",
-            Description = ContextProvider.Get<string>("downloadName"),
-            Fields =
-            [
-                new() { Title = "Hash", Text = ContextProvider.Get<string>("hash").ToLowerInvariant() },
-                new() { Title = "Old category", Text = oldCategory },
-                new() { Title = "New category", Text = newCategory }
-            ],
-            Level = NotificationLevel.Important
-        };
-
-        await NotifyInternal(notification);
-    }
-    
-    private Task NotifyInternal<T>(T message) where T: notnull
-    {
-        return _dryRunInterceptor.InterceptAsync(Notify<T>, message);
-    }
 
     [DryRunSafeguard]
     private Task Notify<T>(T message) where T: notnull

code/Infrastructure/Verticals/Notifications/NotificationService.cs

@@ -73,19 +73,4 @@ public class NotificationService
             }
         }
     }
-    
-    public async Task Notify(CategoryChangedNotification notification)
-    {
-        foreach (INotificationProvider provider in _notificationFactory.OnCategoryChangedEnabled())
-        {
-            try
-            {
-                await provider.OnCategoryChanged(notification);
-            }
-            catch (Exception exception)
-            {
-                _logger.LogWarning(exception, "failed to send notification | provider {provider}", provider.Name);
-            }
-        }
-    }
 }

code/Infrastructure/Verticals/QueueCleaner/QueueCleaner.cs

@@ -119,9 +119,9 @@ public sealed class QueueCleaner : GenericHandler
 
                 bool removeFromClient = true;
 
-                if (stalledCheckResult.IsPrivate)
+                if (stalledCheckResult is { IsPrivate: true, DeleteReason: not DeleteReason.DownloadingMetadata })
                 {
-                    if (stalledCheckResult.ShouldRemove && !_config.StalledDeletePrivate)
+                    if (stalledCheckResult is { ShouldRemove: true, DeleteReason: DeleteReason.Stalled } && !_config.StalledDeletePrivate)
                     {
                         removeFromClient = false;
                     }

code/test/docker-compose.yml

@@ -178,7 +178,7 @@ services:
       - TZ=Europe/Bucharest
       - DRY_RUN=false
 
-      - LOGGING__LOGLEVEL=Verbose
+      - LOGGING__LOGLEVEL=Debug
       - LOGGING__FILE__ENABLED=true
       - LOGGING__FILE__PATH=/var/logs
       - LOGGING__ENHANCED=true
@@ -193,13 +193,14 @@ services:
       - QUEUECLEANER__ENABLED=true
       - QUEUECLEANER__IGNORED_DOWNLOADS_PATH=/ignored
       - QUEUECLEANER__RUNSEQUENTIALLY=true
-      - QUEUECLEANER__IMPORT_FAILED_MAX_STRIKES=5
+      - QUEUECLEANER__IMPORT_FAILED_MAX_STRIKES=3
       - QUEUECLEANER__IMPORT_FAILED_IGNORE_PRIVATE=true
       - QUEUECLEANER__IMPORT_FAILED_DELETE_PRIVATE=false
       - QUEUECLEANER__IMPORT_FAILED_IGNORE_PATTERNS__0=file is a sample
-      - QUEUECLEANER__STALLED_MAX_STRIKES=5
+      - QUEUECLEANER__STALLED_MAX_STRIKES=3
       - QUEUECLEANER__STALLED_IGNORE_PRIVATE=true
       - QUEUECLEANER__STALLED_DELETE_PRIVATE=false
+      - QUEUECLEANER__DOWNLOADING_METADATA_MAX_STRIKES=3
 
       - CONTENTBLOCKER__ENABLED=true
       - CONTENTBLOCKER__IGNORED_DOWNLOADS_PATH=/ignored
@@ -212,15 +213,11 @@ services:
       - DOWNLOADCLEANER__CATEGORIES__0__NAME=tv-sonarr
       - DOWNLOADCLEANER__CATEGORIES__0__MAX_RATIO=-1
       - DOWNLOADCLEANER__CATEGORIES__0__MIN_SEED_TIME=0
-      - DOWNLOADCLEANER__CATEGORIES__0__MAX_SEED_TIME=99999
-      - DOWNLOADCLEANER__CATEGORIES__1__NAME=nohardlink
+      - DOWNLOADCLEANER__CATEGORIES__0__MAX_SEED_TIME=0.01
+      - DOWNLOADCLEANER__CATEGORIES__1__NAME=radarr
       - DOWNLOADCLEANER__CATEGORIES__1__MAX_RATIO=-1
       - DOWNLOADCLEANER__CATEGORIES__1__MIN_SEED_TIME=0
-      - DOWNLOADCLEANER__CATEGORIES__1__MAX_SEED_TIME=99999
-      - DOWNLOADCLEANER__UNLINKED_TARGET_CATEGORY=cleanuperr-unlinked
-      - DOWNLOADCLEANER__UNLINKED_IGNORED_ROOT_DIR=/downloads
-      - DOWNLOADCLEANER__UNLINKED_CATEGORIES__0=tv-sonarr
-      - DOWNLOADCLEANER__UNLINKED_CATEGORIES__1=radarr
+      - DOWNLOADCLEANER__CATEGORIES__1__MAX_SEED_TIME=0.01
 
       - DOWNLOAD_CLIENT=qbittorrent
       - QBITTORRENT__URL=http://qbittorrent:8080
@@ -259,13 +256,11 @@ services:
       # - NOTIFIARR__ON_STALLED_STRIKE=true
       # - NOTIFIARR__ON_QUEUE_ITEM_DELETED=true
       # - NOTIFIARR__ON_DOWNLOAD_CLEANED=true
-      # - NOTIFIARR__ON_CATEGORY_CHANGED=true
       # - NOTIFIARR__API_KEY=notifiarr_secret
       # - NOTIFIARR__CHANNEL_ID=discord_channel_id
     volumes:
       - ./data/cleanuperr/logs:/var/logs
       - ./data/cleanuperr/ignored_downloads:/ignored
-      - ./data/qbittorrent/downloads:/downloads
     restart: unless-stopped
     depends_on:
       - qbittorrent

variables.md

@@ -152,7 +152,7 @@
 #### **`QUEUECLEANER__STALLED_MAX_STRIKES`**
 - Number of strikes before removing a stalled download.
 - Set to `0` to never remove stalled downloads.
-- A strike is given when an item is stalled (not downloading) or stuck while downloading metadata.
+- A strike is given when an item is stalled (not downloading).
 - Type: Integer
 - Default: `0`
 - Required: No.
@@ -184,6 +184,19 @@
 > [!WARNING]
 > Setting `QUEUECLEANER__STALLED_DELETE_PRIVATE=true` means you don't care about seeding, ratio, H&R and potentially losing your private tracker account.
 
+#### **`QUEUECLEANER__DOWNLOADING_METADATA_MAX_STRIKES`**
+- Number of strikes before removing a download stuck while downloading metadata.
+- Set to `0` to never remove downloads stuck at `downloading metadata`.
+- A strike is given when an item is stuck while downloading metadata.
+- Type: Integer
+- Default: `0`
+- Required: No.
+> [!NOTE]
+> If not set to `0`, the minimum value is `3`.
+
+> [!IMPORTANT]
+> `QUEUECLEANER__DOWNLOADING_METADATA_MAX_STRIKES` works only for qBitTorrent.
+
 #
 
 ### Content Blocker settings
@@ -317,7 +330,7 @@
 >
 > For Deluge, the category name is the name of the label.
 >
-> For Transmission, the category name is the last directory from the save location.
+> For Transmission, the category name is the last directory from the save location (e.g. `myCategory` from `/downloads/path/myCategory`).
 
 #### **`DOWNLOADCLEANER__CATEGORIES__0__MAX_RATIO`**
 - Maximum ratio to reach before removing a download.